-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducibility of jupyter notebook example #44
Comments
@arm61 this page in the docs talks about bootstrapping (which needs updating). And possibly means these examples were generated with the old variance estimation scheme. |
Just for tracking - this issue is related to the joss submission: openjournals/joss-reviews#5984 (comment) |
@arm61 I've rerun the notebook, but I still get different results compared to the one shown on documention website. For the same example: https://kinisi.readthedocs.io/en/latest/vasp_dj.html
The webpage shows
However, I got
In addition, these results differ a lot compared to your previous version as shown above, did you change the input parameters? |
I suspect that this is due to small variations in the exact environment that you have. Note that we do no aspire to complete reproducibility between your build of the docs and those online (however, if you rerun the notebook you should get the same numbers repeatably). I am happy to add a statement to this effect to the documentation, but cross-machine reproducibility is a very hard problem so it feels redundant. |
For reference, the difference in the "best-fit" estimate of D_J is ~0.1% the 95% compatibility interval. |
Yeah please add a statement then I'll close this issue. |
Isn't this the case for any numerical (rather than analytical) method? @arm61 maybe a generic statement to cover the entire docs rather than just on this page (and then repeating on other pages?) |
I have added something to the FAQ about this in 0d9a4ab |
This seems like a good place to me. |
I just run the Notebook examples, and I found the number I got is slightly different compared to the number shown on documentation webpage. I assume this is normal right? If so, please indicate there will be some differences when rerun the notebook examples.
One of the example is on https://kinisi.readthedocs.io/en/latest/vasp_dj.html
I got
on the webpage the results are:
The text was updated successfully, but these errors were encountered: