Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Unix-specific file removal code (per #22) #25

Open
bjcairns opened this issue Oct 9, 2019 · 0 comments · May be fixed by #35
Open

Review Unix-specific file removal code (per #22) #25

bjcairns opened this issue Oct 9, 2019 · 0 comments · May be fixed by #35
Assignees
@bjcairns
Labels
minor bug Something minor isn't working

Comments

@bjcairns
Copy link
Owner

bjcairns commented Oct 9, 2019

The use of lsof in #22 will allow testing of code to protect open database files, and error handling is implicit.

However, some errors (especially if lsof is missing/unavailable) will be misreported and better handling might be useful.

This code needs review and consideration on how to best implement this fix to #5.
@bjcairns bjcairns added the minor bug Something minor isn't working label Oct 9, 2019
@bjcairns bjcairns self-assigned this Oct 9, 2019
@bjcairns bjcairns linked a pull request Feb 6, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjcairns bjcairns

Labels
minor bug Something minor isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge dev to master for v0.3.0 release bjcairns/ukbschemas
1 participant
@bjcairns