Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site icons not loading, defaults to NotFound icon #2598

Closed
1 task done
Tracked by #2480
kevjett opened this issue Jan 18, 2023 · 2 comments
Closed
1 task done
Tracked by #2480

Site icons not loading, defaults to NotFound icon #2598

kevjett opened this issue Jan 18, 2023 · 2 comments
Labels
bug bw-unified-deploy An Issue related to Bitwarden unified deployment needs-reply

Comments

@kevjett
Copy link

kevjett commented Jan 18, 2023

Steps To Reproduce

  1. Go to Vault
  2. Click to Add a Login Vault Item
  3. Enter info for new item, use https://www.google.com as URI
  4. Click Save

Expected Result

The new item icon should be a google.com icon.

Actual Result

The new item icon is the NotFound icon of the grey world.

Screenshots or Videos

I attached screenshots of the edit screen and the vault item list. As you can see, the image is the default image.

Screen Shot 2023-01-18 at 4 52 24 PM

Screen Shot 2023-01-18 at 4 52 15 PM

Additional Context

I checked the URL of the image in developer tools and it's set as "https://bitwarden.mydomain.com/icons/www.google.com/icon.png". When I load that URL separately, it returns the default image.

For the logs, I checked the logs of the icon.log file and here is the log.

[40m�[1m�[33mwarn�[39m�[22m�[49m: Bit.Icons.Services.IIconFetchingService[0]
=> SpanId:e8a0f8fb15b55610, TraceId:980ee061ae7a9e011f00059aeb513acf, ParentId:0000000000000000 => ConnectionId:0HMNP9UKPVJ85 => RequestPath:/www.google.com/icon.png RequestId:0HMNP9UKPVJ85:00000002 => Bit.Icons.Controllers.IconsController.Get (Icons)
Couldn't load a website for www.google.com: null.
�[40m�[1m�[33mwarn�[39m�[22m�[49m: Bit.Icons.Controllers.IconsController[0]
=> SpanId:e8a0f8fb15b55610, TraceId:980ee061ae7a9e011f00059aeb513acf, ParentId:0000000000000000 => ConnectionId:0HMNP9UKPVJ85 => RequestPath:/www.google.com/icon.png RequestId:0HMNP9UKPVJ85:00000002 => Bit.Icons.Controllers.IconsController.Get (Icons)
Null result returned for www.google.com.`

I also went into the console for the bitwarden-unified-bitwarden docker container to make sure I could ping www.google.com, and I was able to ping out from the docker container.

So, I'm not sure why the Icon finder service cannot access external URLs. This is the same result for all URLs and it produces the same log for all of them.

Githash Version

3997def-dirty

Environment Details

  • Operating System: Windows 10
  • Environment: Docker
  • i7 Intel processor, 16 GB ram

Database Image

mariadb:10

Issue-Link

#2480

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@kevjett kevjett added bug bw-unified-deploy An Issue related to Bitwarden unified deployment labels Jan 18, 2023
@kspearrin
Copy link
Member

I am not able to reproduce the issue. Are you fronting the installation with a proxy or something? Perhaps there is some caching going on that is holding a failed resolution of the image on a previous request? Could you try some other random domains like:

https://bitwarden.mydomain.com/icons/yahoo.com/icon.png
https://bitwarden.mydomain.com/icons/github.com/icon.png
https://bitwarden.mydomain.com/icons/reddit.com/icon.png

@github-actions
Copy link
Contributor

We need more information before we can help you with your problem. As we haven’t heard from you recently, this issue will be closed.

If this happens again or continues to be an problem, please respond to this issue with the information we’ve requested and anything else relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bw-unified-deploy An Issue related to Bitwarden unified deployment needs-reply
Projects
None yet
Development

No branches or pull requests

3 participants