Multithreading improvements #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit comments look awesome. I can't wait to dig in! |
|
Restarted Travis build. It complained that received no output when running |
jmjatlanta
suggested changes
Nov 10, 2018
| } | ||
| else | ||
| { // possibly shutdown? | ||
| std::cerr << "unhandled exception in thread '" << name << "'\n"; |
There was a problem hiding this comment.
To compile on Ubuntu 18.04, need to include iostream or remove stdout streams
| if( !strcmp( boost::unit_test::framework::master_test_suite().argv[i], "--pool-threads" ) ) | ||
| { | ||
| uint16_t threads = atoi(boost::unit_test::framework::master_test_suite().argv[++i]); | ||
| std::cout << "Using " << threads << " pool threads\n"; |
There was a problem hiding this comment.
To compile on Ubuntu 18.04, need to remove stdout streams or include iostream header
jmjatlanta
suggested changes
Nov 13, 2018
| }; | ||
|
|
||
| friend class ticket_guard; | ||
| boost::atomic<future<void>*> latch; |
There was a problem hiding this comment.
need to include boost/atomic/atomic.hpp to compile in Windows.
jmjatlanta
approved these changes
Nov 16, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of bitshares/bitshares-core#1079
Work in progress, please do not merge yet!