Websocketpp 0.8.2

[abitmore]

User Story
Due to a bug or two in websocketpp 0.7.0, we forked websocketpp and applied patches by ourselves.

Now Websocketpp 0.8.1 has been released: https://github.com/zaphoyd/websocketpp/releases/tag/0.8.1.

Update: websocketpp 0.8.2 was released with a fix for zaphoyd/websocketpp#794.

This ticket is for testing it.

CORE TEAM TASK LIST

• Evaluate / Prioritize Feature Request
  • Assigned: @dmarcosa
  • Estimation: Pending
• Refine User Stories / Requirements
• Define Test Cases
• Design / Develop Solution
• Perform QA/Testing
• Update Documentation

[ryanRfox]

@dmarcosa I assigned this ticket to you in our 201904 Feature Release. Please help me by providing a Task List with some estimates for this Issue. It's not clear to me if it will involve removing our forked 0.7.0 websockets code and replacing it with the upstream 0.8.1 code. Thanks.

[clockworkgr]

Chances of evaluating changing the library? (possibly https://github.com/uNetworking/uWebSockets)

[pmconrad]

@dmarcosa are you working on this? What's the status?

[jmjatlanta]

I merged the master branch of zaphoyd/websocketpp into libraries/fc/vendor/websocketpp. That caused 1 small conflict (spacing), and compiled without error. Some fc tests fail.

"fc_network/websocket_test": boost::exception_detail::clone_impl<boost::exception_detail::error_info_injectorboost::system::system_error >: set_option: Bad file descriptor
/home/jmjatlanta/Development/cpp/bitshares-core-1134/libraries/fc/tests/network/http/websocket_test.cpp(9): last checkpoint: "websocket_test" test entry

"api_tests/login_test": unknown type
/home/jmjatlanta/Development/cpp/bitshares-core-1134/libraries/fc/tests/api_tests.cpp(64): last checkpoint: "login_test" test entry

"api_tests/optionals_test": unknown type
/home/jmjatlanta/Development/cpp/bitshares-core-1134/libraries/fc/tests/api_tests.cpp(107): last checkpoint

[pmconrad]

IIRC it does compile but isn't working properly, because upstream changed a hook where we set socket options or sth like that.

[jmjatlanta]

Related: #1735 (comment)

What steemit is doing to allow Boost 1.70 without upgrading websocketpp.

[abitmore]

It seems that Steem has upgraded to websocketpp 0.8.1 long before: steemit/steem#3119.

Note: zaphoyd/websocketpp#794 (bitshares/websocketpp#3) is still needed.

[abitmore]

Update: websocketpp 0.8.2 was released with a fix for zaphoyd/websocketpp#794.