Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcconfig file handling fix #49

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Xcconfig file handling fix #49

merged 3 commits into from
Jul 24, 2024

Conversation

tothszabi
Copy link
Contributor

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a MINOR version update

Context

The step was not handling the case when the info plist path is defined in an xcconfig file.

The new logic is that if the mandatory plist path is not in the project settings then it will use xcodebuild to resolve the xconfig files. And it uses xcodebuild because the xconfig files could import other xcconfig file so parsing them manually is not that simple.

@tothszabi tothszabi merged commit 590bee6 into master Jul 24, 2024
1 check passed
@tothszabi tothszabi deleted the xcconfig-file-handling-fix branch July 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants