Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-2872] Add more logging #45

Merged
merged 1 commit into from
Apr 30, 2024
Merged

[CI-2872] Add more logging #45

merged 1 commit into from
Apr 30, 2024

Conversation

tothszabi
Copy link
Contributor

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

There was a recent SWAT ticket where this step worked differently than the customers bash script. Upon further investigation I think the step was configured differently that the bash script and that caused the version numbers not being updated.

I have included some extra logs to help debug future issues.

Changes

There is a new verbose input which will make the step print more useful logs for debugging. The new debug logs will look like this:

Updating build settings for the Example target
CURRENT_PROJECT_VERSION 1 -> 9999
MARKETING_VERSION 1.0 -> 9.99.9

and

Updating Info.plist at /Users/szabi/Dev/bitrise-steplib/steps-set-xcode-build-number/testdata/project/Example/Example/Example-Static-Info.plist
CFBundleVersion 19876 -> 9999
CFBundleShortVersionString 12.5.5 -> 9.99.9

So it will print out which target or info.plist path is being updated and also it will print the old values too.

@tothszabi tothszabi merged commit 84a6897 into master Apr 30, 2024
1 check passed
@tothszabi tothszabi deleted the CI-2872-more-logging branch April 30, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants