Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change BuildVersion to int64 allowing larger build numbers #37

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

asserh
Copy link
Contributor

@asserh asserh commented Feb 9, 2024

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a patch version.

Context

Changes build_version to an int64, allowing larger numbers to be used as the build number.

#36

Changes

BuildVersion is now int64 (instead of an int)

Investigation details

This was not an issue on previous versions, our builds started failing once 2.0 was released. Might be others affected that use similar format for their builds

@tothszabi
Copy link
Contributor

tothszabi commented Feb 15, 2024

Hey @asserh thanks for the PR. I have made some fixes in the meantime and merged master into your fork. But unfortunately this means that could you update one more thing in your PR?

In the step/step.go file on line 141 I had to add another int -> string conversion and could you update that as well just like you did for the others?

Now because of this the CI is failing and I cannot merge your PR.

@asserh
Copy link
Contributor Author

asserh commented Feb 19, 2024

Gotcha! I pushed a commit that fixes that line. Now it also converts from int64. I just pushed the fix on top, let me know if you need me to rebase to include it in the original commit. Perhaps you squash PR:s anyway when merging?

Copy link
Contributor

@ofalvai ofalvai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now @asserh, thank you for the contribution! 💯
Yes, we do squash merges, it's all good from now on

@ofalvai ofalvai merged commit f48226b into bitrise-steplib:master Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants