Improve Gradle command error messages #99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.yml
andREADME.md
is updated with the changes (if needed)Version
Requires a MINOR version update
Context
This PR improves the error messages logged by the Step. Currently, the step prints the whole output of the
gradle dependencies
command into the error message, which makes it noisy.The primary goal was logging relevant messages when
gradle dependencies
fails.Resolves: https://bitrise.atlassian.net/browse/BIVS-1951
Changes
gradle dependencies
command's stderr is used as a failure reasonAndroidToolsInstaller.ProcessInputs
andAndroidToolsInstaller.Run
and wire in formatted error messagesInvestigation details
Initially, I started by writing a custom parser to gather relevant details from the Gradle command execution output, but it turned out Gradle prints the failure reason to the stderr.
Decisions
gradle dependencies
command's stderr might contain a stacktrace, which can be a long message. We might consider truncating it, in the future if it causes too much noise in the error messages.