Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOOL-317 #55

Merged
merged 2 commits into from
Jul 4, 2019
Merged

TOOL-317 #55

merged 2 commits into from
Jul 4, 2019

Conversation

richard-bogdan-bitrise
Copy link
Contributor

Added test case for a project with androidx dependencies. Fixed support lib regex.

koral--
koral-- reviewed Jul 3, 2019
View reviewed changes
bitrise.yml Outdated
@@ -240,6 +240,48 @@ workflows:
- path::./:
title: Step test

test_support_library:
envs:
- SAMPLE_APP_URL: https://github.com/godrei/JetPackTest.git
Copy link
Contributor

@koral-- koral-- Jul 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Samples should be located in bitrise-io organization.
BTW all other sample URLs in this file point to bitrise-samples org which is deprecated and contains no repos now (there are redirects to bitrise-io).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@BirmacherAkos
Copy link

BirmacherAkos commented Jul 4, 2019 •
edited
Loading

It was no your task, but as maintenance please fix the next:

Please update the Bitrise.yml:

  • Please use this repo for androidX test sample (it's a same but in the right organization)
    https://github.com/bitrise-io/sample-apps-android-x .
  • Update the format version to the newest (8)
  • Our new release flow does not use the STEP_VERSION env anymore, it depends on the tag now. Please remove it.
  • Please update the sample-apps-android-sdk22 sample's Github org to bitrise-io. We moved all the repos under to bitrise-io or bitrise-steplib orgs months ago. The bitrise-sample ones has been moved to bitrise-io
  • Do the org update for the other samples as well in the Bitrise.yml.
  • Please remove the create-release workflow. The new release flow does not use it.
  • Please remove the share-this-step workflow. The new release flow does not use it.
  • Please add a before_run to the ci workflow:
before_run:
- audit-this-step

BirmacherAkos
BirmacherAkos requested changes Jul 4, 2019
View reviewed changes
Copy link

@BirmacherAkos BirmacherAkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments

@richard-bogdan-bitrise
Copy link
Contributor Author

Fixed review comments.

@BirmacherAkos BirmacherAkos merged commit ae54ed0 into master Jul 4, 2019
@BirmacherAkos BirmacherAkos deleted the TOOL-317 branch July 4, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koral-- koral-- koral-- left review comments

@BirmacherAkos BirmacherAkos BirmacherAkos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-bogdan-bitrise @BirmacherAkos @koral--