Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped step warning misaligned if there are steps between failed and skipped one #546

Open
koral-- opened this issue Nov 9, 2017 · 1 comment
Assignees

Comments

@koral--
Copy link
Contributor

koral-- commented Nov 9, 2017

+---+---------------------------------------------------------------+----------+
| x | Gradle UI Test (exit code: 1)                                 | 83 sec   |
+---+---------------------------------------------------------------+----------+
| Issue tracker: https://github.com/bitrise-io/steps-gradle-unit-test/issues   |
| Source: https://github.com/bitrise-io/steps-gradle-unit-test                 |
+---+---------------------------------------------------------------+----------+
| ✓ | openstf-disconnect                                            | 22 sec   |
WARN[21:08:36] A previous step failed, and this step (cache-push) was not marked as IsAlwaysRun, skipped 
+---+---------------------------------------------------------------+----------+
| ✓ | activate-ssh-key                                              | 1.05 sec |
+---+---------------------------------------------------------------+----------+
| ✓ | git::https://github.com/DroidsOnRoids/bitrise-step-publish-...| 12 sec   |
+---+---------------------------------------------------------------+----------+
| - | cache-push                                                    | 6.16 sec |
+---+---------------------------------------------------------------+----------+
| Total runtime: 338 sec                                                       |
+------------------------------------------------------------------------------+

It seems that a warning A previous step failed, and this step... is printed in the step following failed one (or it is not synchronized at all with the step list).

In the example above it should be printed inside the last step row. Or at least warning should be reworded to not contain misleading this.

CLI version 1.10.0
Build URL: https://www.bitrise.io/build/903f5f8d6fd553ad

@erosdome
Copy link
Contributor

erosdome commented Nov 9, 2017

Hi, the problem is more likely with it not being synchronized with the step list, as you metioned. We will add this to our todo list and fix it as soon as possible. Thanks for reporting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants