Backup names do not include metadata.name

[ballad89]

apiVersion: mysql.presslabs.org/v1alpha1
kind: MysqlBackup
metadata:
  namespace: test-namespace
  name: baseline
spec:
  clusterName: mysql-cluster

Currently the above backup would be named mysql-cluster-<date>... on s3.
I think the name of the backup should be included in the name such as mysql-cluster-baseline-<date>... as it would provide a way to identify and differentiate backups.
Or it can even be called baseline-<date>... as that is the name specified.
In summary, a way to control what my snapshots are called would be nice

[AMecea]

Hi @ballad89, thanks for opening this issue, I agree with you, I think that the backup on remote should be called baseline-<date>....

I'd be happy to review and merge a PR that does that. 😄

Here is how bucket URL is composed.

[ballad89]

Cool, not a problem. Could you just walk me through how you setup and test locally ? thanks

[AMecea]

Sure,

EDIT: In order to get the project working locally you had to install kubebuilder.

After cloning the repo in your go path (~/go/src/github.com/presslabs/mysql-operator) run:

# to install ginkgo, golangci-linter, helm, yq  (in local bin folder of the project)
make dependencies-local

# run unit and integration tests
make

# run linter
make lint

If you want to test it in minikube or on a remote cluster, you can use skaffold

# connects to your cluster and deploys an instance of mysql-operator. (make sure that no other release of the operator is running)
make skaffold-run

Note: skaffold will fail to publish images so you have to adapt the skaffold.yaml file to not publish the images if you are using minikube.

Hope this helps! Please let me know if something does not work or if you have any questions.

[ballad89]

PR submitted
#257

In order to get the project working locally I had to install kubebuilder globally https://book.kubebuilder.io/getting_started/installation_and_setup.html#

[AMecea]

Addressed by #257

[ballad89]

Any release scheduled for soon ?

[AMecea]

We want to do a new release every two weeks. So the next version (0.2.7) is planned to be released on Monday.