You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
line 1004:
// if no change output is set, fees should equal all the unspent amount
if (!this._changeScript) {
return this._getUnspentValue();
}
Comment for function says estimate fee, but if inputs=outputs it will return 0 instead of estimating. And even if they are
not equal it will return 'all the unspent amount' instead of estimating an appropriate fee.
So function does not do what it says it will.
bitcore/packages/bitcore-lib/lib/transaction/transaction.js
Line 992 in 7dd58ea
line 1004:
// if no change output is set, fees should equal all the unspent amount
if (!this._changeScript) {
return this._getUnspentValue();
}
Comment for function says estimate fee, but if inputs=outputs it will return 0 instead of estimating. And even if they are
not equal it will return 'all the unspent amount' instead of estimating an appropriate fee.
So function does not do what it says it will.
This problem is the same for dogecoin
https://github.com/bitpay/bitcore/blob/master/packages/bitcore-lib-doge/lib/transaction/transaction.js#L999
The text was updated successfully, but these errors were encountered: