Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Sets the redirect URL default to the original request's path instead … #587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sets the redirect URL default to the original request's path instead … #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion oauthproxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ func (p *OAuthProxy) GetRedirect(req *http.Request) (redirect string, err error)

redirect = req.Form.Get("rd")
if redirect == "" || !strings.HasPrefix(redirect, "/") || strings.HasPrefix(redirect, "//") {
redirect = "/"
redirect = req.URL.Path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not work out because if you visited /oauth2/sign_in or /oauth2/start explicitly, then you end up in a loop

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using like this?

if req.Header.Get("X-Auth-Request-Redirect") != "" {
    redirect = req.Header.Get("X-Auth-Request-Redirect")
}

}

return
Expand Down