Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't sign PSBTs with mobile key #5545

Open
mattcrv opened this issue Nov 7, 2024 · 5 comments
Open

Can't sign PSBTs with mobile key #5545

mattcrv opened this issue Nov 7, 2024 · 5 comments
Labels
Status: to-do 📋 Items not yet picked up

Comments

@mattcrv
Copy link

mattcrv commented Nov 7, 2024

Describe the bug
I often get a join.decode input should be string error when trying to scan a PSBT from another Keeper app to sign with my mobile key on Keeper. Sometimes, the scan also gets stuck at 75% without showing any error, and occasionally, pasting shows 100% but doesn’t proceed to the next screen.

To Reproduce

  1. Create a collaborative Vault with one local mobile key and two external keys that are mobile keys generated by other Keeper apps
  2. Generate a PSBT
  3. Scan or paste the PSBT
  4. See error

Expected behavior
Transaction signed.

Smartphone (please complete the following information):

  • Device: iPhone 15 Pro
  • OS: iOS 18.2
  • Version 1.2.16
@mattcrv mattcrv added the Status: to-do 📋 Items not yet picked up label Nov 7, 2024
@ben-kaufman
Copy link
Contributor

Hi, I believe this has been fixed as part of version 1.2.17, which got delayed for iOS due to some issues with some new Apple regulations.

We have resolved all that and should have a new release which includes a fix for the issue out next week. I will also write here when it's out. Please try with the new release when it's out and let us know if you are still experiencing any issues.

@mattcrv
Copy link
Author

mattcrv commented Nov 9, 2024

Thank you! Unfortunately, I just tested 1.2.18 (413) and the issue persists.

@ben-kaufman
Copy link
Contributor

Hmm, strange, we have tested that flow and couldn't see the issue. Did you update the Keeper app on all devices involved in the transaction? Also maybe try to start over the process by deleting the pending transaction and creating a new PSBT?

@mattcrv
Copy link
Author

mattcrv commented Nov 11, 2024

All devices involved downloaded the app for the first time on the Eastern Time morning of Nov 9. Version 1.2.18 was already released on both iOS and Android by then, so they were all using it.

This happened during a demonstration to 3 people at a conference. Once the bug occurred, I did ask a different person in the group to create the PSBT for the other two to sign, but that still didn’t work. Unfortunately, I’m no longer in touch with them, so I can’t ask them to delete the PSBT and retry.

I don’t plan to try this flow again anytime soon, so feel free to close this issue if it’s indeed already resolved.

@ben-kaufman
Copy link
Contributor

Ok, thanks trying it out and letting us know.

We will do more internal testing and try to see if we can reproduce the issues. I believe the issue was related to one which was fixed in the last release since we had this error message before on certain QR scanning, and it should not be appearing anymore for the newer release, but we will check it more extensively internally to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: to-do 📋 Items not yet picked up
Projects
None yet
Development

No branches or pull requests

2 participants