LocalAddressBook: call updateSyncFrameworkSettings when address books are renamed

[rfc2822]

Currently, updateSyncFrameworkSettings is only called on create() and update().

This may cause extra syncs when address books are renamed.

It fixes itself anyway because sooner or later when LocalAddressBook.update() is called, which in turn calls updateSyncFrameworkSettings. However it should already be done correctly at the first try.

[sunkup]

renameAccount() is only ever called from update(). Inside update(), updateSyncFrameworkSettings() is called unconditionally at the end of the method.

So my understanding is that every call of update() will always call updateSyncFrameworkSettings() and therefore updateSyncFrameworkSettings() will be called when address books are renamed.

However it should already be done correctly at the first try.

What exactly do you mean by this. Am I overlooking something?

[rfc2822]

Yes, update, but not create. I think in the time between (address book has been created) and (first sync has called update()) the address book account is in an undefined state regarding the sync framework.

I think this causes extra automatic (initial periodic) syncs from the sync framework.

I'm not really sure but after the migration to 4.4.3.2 there are some unnecessary extra syncs which made me curious. As soon as the syncs are completed, there are no more additional extra syncs, so I suspect this could be because of that.

[sunkup]

updateSyncFrameworkSettings() is already called inside update() after renameAccount(). No need to call it inside renameAccount() too.