Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use timezone ID instead of full VTIMEZONE in DB #1052

Open
3 tasks done
rfc2822 opened this issue Oct 2, 2024 · 1 comment · May be fixed by #1104
Open
3 tasks done

Use timezone ID instead of full VTIMEZONE in DB #1052

rfc2822 opened this issue Oct 2, 2024 · 1 comment · May be fixed by #1104
Assignees
@ArnyminerZ
Labels
refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Oct 2, 2024 •
edited by ArnyminerZ
Loading

Currently we use the full VTIMEZONE from the server in the Collection table.

However we only use the ID and have to extract it every time (and Calendar Provider doesn't support custom VTIMEZONEs anyway), so it seems more useful to have only the tz id there.

Requires DB migration.

(Not urgent, for somewhen)

Depends on #1044

  • Send calendar-timezone-id with MKCALENDAR
  • Request and process calendar-timezone-id, if available (fall back to calendar-timezone)
  • Store timezone ID instead of VTIMEZONE in database (+ migration)
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Oct 2, 2024
@rfc2822 rfc2822 mentioned this issue Oct 7, 2024
Merged
4 tasks
@github-actions github-actions bot removed the dependent label Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

This PR/issue depends on:

@ArnyminerZ ArnyminerZ linked a pull request Oct 25, 2024 that will close this issue
Use timezone ID instead of full VTIMEZONE in DB #1104
Open
4 tasks
@sunkup sunkup moved this from Todo to In Progress in DAVx⁵ Releases Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
DAVx⁵ Releases
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use timezone ID instead of full VTIMEZONE in DB bitfireAT/davx5-ose
2 participants
@rfc2822 @ArnyminerZ