Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling the capture SDK #63

Open
pyricau opened this issue Oct 4, 2024 · 4 comments
Open

Support disabling the capture SDK #63

pyricau opened this issue Oct 4, 2024 · 4 comments

Comments

@pyricau
Copy link

pyricau commented Oct 4, 2024

There doesn't seem to be a way to turn off the SDK? i.e. once configured, it's running. Ideally we could have a flag and live turn it on / off, which would make us feel safer about rolling it out

@mattklein123
Copy link
Contributor

@pyricau disable semantics are a bit complicated. What is the behavior that you want to see? Something like no more network traffic and all logging functions become NOP? Something else?

@mattklein123
Copy link
Contributor

(We have an internal mechanism to kill all network traffic already but would want to better understand what else you would want exposed.)

@murki
Copy link
Contributor

murki commented Oct 16, 2024

This is particularly important for the case of enabled-by-default, disabled-by-request, since it makes sense that the SDK would be initialized early on and potentially disabled on demand later. We will work on adding this.

@pyricau
Copy link
Author

pyricau commented Dec 16, 2024

Something like no more network traffic and all logging functions become NOP? Something else?

Yes, and any / all background threads as well.

We've unfortunately had the experience of some other observability vendors that should remain unnamed creating issues in prod, so we're now very cautious and like the ability to turn things off, especially in a context where our app runs all day in foreground so waiting for the next app start doesn't cut it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants