Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cload wsl recipe overwritten #982

Closed
knmcguire opened this issue Mar 7, 2022 · 2 comments · Fixed by #989
Closed

make cload wsl recipe overwritten #982

knmcguire opened this issue Mar 7, 2022 · 2 comments · Fixed by #989
Labels
Milestone

Comments

@knmcguire
Copy link
Contributor

With the latest changes, make cload seems to be broken for WSL:

tools/kbuild/Makefile.kbuild:147: warning: overriding recipe for target 'cload'
Makefile:136: warning: ignoring old recipe for target 'cload'
make[1]: Entering directory '/home/kimberly/Development/c/crazyflie-firmware/build'
  GEN     ./Makefile
scripts/kconfig/conf  --silentoldconfig Kconfig
python3 -m cfloader  flash  cf2.bin stm32-fw
Restart the Crazyflie you want to bootload in the next
 10 seconds ...
Failed to flash: Cannot find a Crazyradio Dongle
make[1]: Leaving directory '/home/kimberly/Development/c/crazyflie-firmware/build'

it should write python.exe. The warning indicates that the recipe for cload is overwritten, but not exactly sure how this happens from the kbuild file.

@knmcguire knmcguire added the bug label Mar 7, 2022
@knmcguire
Copy link
Contributor Author

This happens in Ubuntu too btw, ofcourse it does not have as drastic effect, but it is still bad that this is overwritten...

It has something to do with the line mentioned in the Makefile.kbuild file in tools

$(filter-out _all sub-make $(CURDIR)/Makefile, $(MAKECMDGOALS)) _all: sub-make
	@:

@knmcguire knmcguire changed the title make cload wsl broken make cload wsl recipe overwritten Mar 8, 2022
@krichardsson
Copy link
Contributor

As far as I understand the root problem for this issue was actually that make cload does not work on Windows as make tries to use the wrong python binary (python3 instead of python.exe), correct @knmcguire ?
The pull request #989 solves that problem

The warning

tools/kbuild/Makefile.kbuild:147: warning: overriding recipe for target 'cload'
Makefile:136: warning: ignoring old recipe for target 'cload'

does not seem to be related to this problem, I do not know why we get that and it still remains to be solved.

@knmcguire knmcguire added this to the next-release milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants