Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin loops in uart send functions #883

Closed
krichardsson opened this issue Nov 11, 2021 · 1 comment
Closed

Spin loops in uart send functions #883

krichardsson opened this issue Nov 11, 2021 · 1 comment

Comments

@krichardsson
Copy link
Contributor

The uart1SendData() and uart2SendData() functions uses a spin loop to determine when the next byte can be pushed to the UART. Sending too much data continuously using these functions will block the task and is likely to cause starvation problems in the system.

Note: uart1Putchar() and uart2Putchar() are calling the send data functions and have the same problem

The suggested solution is to replace the spin loop with an interrupt and semaphore.

@knmcguire knmcguire linked a pull request Sep 6, 2022 that will close this issue
@knmcguire
Copy link
Member

knmcguire commented Sep 6, 2022

fixed by #1065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants