Adaptations in Weight Calculation Methods #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update ensure that `@bitcoinerlab/coinselect` takes full advantage of the recent improvements in the `@bitcoinerlab/descriptors` package, particularly the new weight calculation methods. This alignment enhances the performance of coin selection and transaction size estimation since it now relies on smarter caching strategies implemented in `@bitcoinerlab/descriptors`. It aligns with the recent enhancements and new functionalities in weight calculation methods introduced in `@bitcoinerlab/descriptors` ([PR #32](bitcoinerlab/descriptors#32)). **Key Changes:** 1. **Package Version and Dependencies:** - Upgraded `@bitcoinerlab/coinselect` from version `1.1.0` to `1.2.0`. - Updated the dependency on `@bitcoinerlab/descriptors` to version `2.1.0` to leverage the latest enhancements. 2. **Code Refactoring:** - Removed local implementations of weight calculations (`inputWeight` and `outputWeight`) and replaced them with the updated methods from `@bitcoinerlab/descriptors`. - Simplified and streamlined the code by removing redundant functions and logic, relying on the improved functionalities in the `descriptors` package. 3. **Validation and Dust Calculation Adjustments:** - Updated the validation logic to incorporate changes in dust calculation and fee rate validation. - Ensured compatibility with the new weight calculation methods in handling UTXOs and transaction outputs. 4. **Test Suite Enhancements:** - Revised test cases to align with the updated logic and methods. Updates and modifications have been appropriately commented and documented within the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensure that
@bitcoinerlab/coinselecttakes full advantage of the recent improvements in the@bitcoinerlab/descriptorspackage, particularly the new weight calculation methods. This alignment enhances the performance of coin selection and transaction size estimation since it now relies on smarter caching strategies implemented in@bitcoinerlab/descriptors.It aligns with the recent enhancements and new functionalities in weight calculation methods introduced in
@bitcoinerlab/descriptors(PR #32).Key Changes:
Package Version and Dependencies:
@bitcoinerlab/coinselectfrom version1.1.0to1.2.0.@bitcoinerlab/descriptorsto version2.1.0to leverage the latest enhancements.Code Refactoring:
inputWeightandoutputWeight) and replaced them with the updated methods from@bitcoinerlab/descriptors.descriptorspackage.Validation and Dust Calculation Adjustments:
Test Suite Enhancements:
Updates and modifications have been appropriately commented and documented within the code.