Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPFP: Allow telling coin selector that a candidate has unconfirmed parents #24

Open
LLFourn opened this issue Apr 2, 2024 · 1 comment

Comments

@LLFourn
Copy link
Collaborator

LLFourn commented Apr 2, 2024

I guess this is just a new field on Candidate which lets you say the combined weight and fee of all parents. I think the approach to use in practice in bdk is to roll all inputs that are in an unconfirmed tree into a single candidate. This will give you the correct answer but has the disadvantage of forcing you to spend them altogether. Needs some design work before trying to implement it. Looking at the actual CPFP related logic in core might provide some inspiration.

@murchandamus
Copy link

Unfortunately, the problem of assessing the effective feerate of a new transaction in the context of its ancestry can become fairly complex to assess. E.g. when parents have a higher feerate than the transaction to be created, they do not encumber the confirmation of the new transaction; or when a lower feerate parent transaction is already reprioritized by another child transaction, it may similarly not require a bump.

We worked on solving this problem for Bitcoin Core in bitcoin/bitcoin#27021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants