Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Drain to Change #22

Open
LLFourn opened this issue Jan 25, 2024 · 0 comments
Open

Rename Drain to Change #22

LLFourn opened this issue Jan 25, 2024 · 0 comments

Comments

@LLFourn
Copy link
Collaborator

LLFourn commented Jan 25, 2024

When I originally named change outputs "drain" outputs I thought I was being clever because sometimes you use these kinds of outputs to drain value to things that are not technically change addresses. However the conversation over here led me to think about what you would do if you wanted to drain a bunch of funds to an output e.g. sweep a wallet or something and my conclusion was that you would actually not use the Drain system but rather:

  1. Set an output whose value is above dust
  2. Select all the things somehow
  3. Set the value of the output to the excess

The main point being that "drain" system we have is really an optional output system to take excess otherwise known as change output or it is at least close enough it's unhelpful to name it something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant