Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BIP47 support #982

Closed
Sosthene00 opened this issue May 19, 2023 · 4 comments
Closed

Adding BIP47 support #982

Sosthene00 opened this issue May 19, 2023 · 4 comments
Labels
new feature New feature or request

Comments

@Sosthene00
Copy link

I still think it would be useful for bdk to support bip47, and if the maintainers agree with that I'd like to open a new PR that will resume work already made in #574 (see it for use case, rationale, and additional context).

As for the debate around bip47, I think pretty much everything have already been said, and I don't intend to argue over it again here.

I tried to rebase and rework the previous PR over 1.0.0-alpha release, but it's actually not that trivial. Besides I worry that there's some of the WIP that could impact an eventual bip47 support.

@Sosthene00 Sosthene00 added the new feature New feature or request label May 19, 2023
@notmandatory
Copy link
Member

I think this would probably better to tackle as a separate crate that works with the new bdk 1.0 APIs after they are settled.

@nondiremanuel
Copy link

I think this would probably better to tackle as a separate crate that works with the new bdk 1.0 APIs after they are settled.

Should I assign it to BDK 1.0 project then?

@notmandatory
Copy link
Member

notmandatory commented May 23, 2023

Should I assign it to BDK 1.0 project then?

No, in this case since it should be a project outside of the bitcoindevkit project org it won't be on any of our project boards. In the future if any help/support discussion issues come up those may go to the 1.0 project board.

@Sosthene00
Copy link
Author

I think this would probably better to tackle as a separate crate that works with the new bdk 1.0 APIs after they are settled.

Thanks for the feedback after spending a few hours fiddling with bdk 1.0 I actually agree. I will think it again as a separate crate and wait for the bdk API to stabilize.

Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants