Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdk_esplora redundantly stores height in its anchor #1233

Open
LLFourn opened this issue Nov 30, 2023 · 0 comments
Open

bdk_esplora redundantly stores height in its anchor #1233

LLFourn opened this issue Nov 30, 2023 · 0 comments
Labels
api A breaking API change module-blockchain new feature New feature or request

Comments

@LLFourn
Copy link
Contributor

LLFourn commented Nov 30, 2023

See:

Some(ConfirmationTimeHeightAnchor {
anchor_block: BlockId { height, hash },
confirmation_height: height,
confirmation_time: time,
})

Esplora should have its own anchor which is BlockIdWithTime for example. It can still be defined in bdk_chain and shouldn't cause friction if the requisite From implementations are done for ConfirmationTimeHeightAnchor.

@notmandatory notmandatory added this to BDK Dec 1, 2023
@notmandatory notmandatory moved this to Todo in BDK Dec 1, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.4 milestone Dec 1, 2023
@nondiremanuel nondiremanuel modified the milestones: 1.0.0-alpha.4, 1.0.0 Jan 6, 2024
@notmandatory notmandatory added module-blockchain api A breaking API change new feature New feature or request labels Mar 18, 2024
@notmandatory notmandatory removed this from the 1.0.0-alpha milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api A breaking API change module-blockchain new feature New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants