Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further enhancements to Update and ChangeSet structures #1061

Closed
Tracked by #72
evanlinjin opened this issue Aug 7, 2023 · 5 comments · Fixed by #1084
Closed
Tracked by #72

Further enhancements to Update and ChangeSet structures #1061

evanlinjin opened this issue Aug 7, 2023 · 5 comments · Fixed by #1084
Assignees
Labels
new feature New feature or request
Milestone

Comments

@evanlinjin
Copy link
Member

Describe the enhancement

As suggested by @LLFourn:

  1. LocalUpdate should be moved to bdk Wallet.
  2. We shouldn't use LocalUpdate in electrum API (it doesn't need to be there IMO).
  3. Delete LocalChangeSet or move it to bdk Wallet. We should implement Append for tuples (A,B) where A: Append, B:Append and use this as our changeset in the examples instead of LocalChangeSet. i.e. we can just go type ChangeSet = (local_chain::ChangeSet, indexed_tx_graph::ChangeSet<...>)
@evanlinjin evanlinjin added the new feature New feature or request label Aug 7, 2023
@evanlinjin
Copy link
Member Author

We also need to remove preview_.. methods from TxGraph since it is a monotone structure now.

@evanlinjin
Copy link
Member Author

Something else I realized, is the ForEachTxOut trait strictly needed still?

@LLFourn
Copy link
Contributor

LLFourn commented Aug 9, 2023

We also need to remove preview_.. methods from TxGraph since it is a monotone structure now.

This is done in #1065 I think.

@vladimirfomene
Copy link
Contributor

Hi @evanlinjin ! I will like to take this up.

@evanlinjin
Copy link
Member Author

@vladimirfomene Thanks for taking this on. Go hard!

@nondiremanuel nondiremanuel added this to the 1.0.0-alpha.3 milestone Aug 15, 2023
@nondiremanuel nondiremanuel moved this to In Progress in BDK Aug 22, 2023
@nondiremanuel nondiremanuel moved this from In Progress to Needs Review in BDK Sep 10, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants