Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename methods of EsploraExt and EsploraAsyncExt #1058

Closed
evanlinjin opened this issue Aug 4, 2023 · 0 comments · Fixed by #1070
Closed

Rename methods of EsploraExt and EsploraAsyncExt #1058

evanlinjin opened this issue Aug 4, 2023 · 0 comments · Fixed by #1070
Assignees
@vladimirfomene
Milestone
1.0.0-alpha.2

Comments

@evanlinjin
Copy link
Member 

          This method should not be called `update_tx_graph` since in the context of that library it is not updating anything. It's returning transaction relevant to a bunch of filters. I'd just call them `scan_txs` and `scan_txs_with_keychains`.

Originally posted by @LLFourn in #1040 (comment)
@evanlinjin evanlinjin mentioned this issue Aug 4, 2023
Merged
4 tasks
@vladimirfomene vladimirfomene mentioned this issue Aug 9, 2023
Merged
5 tasks
@vladimirfomene vladimirfomene self-assigned this Aug 9, 2023
@notmandatory notmandatory added this to BDK Aug 10, 2023
@notmandatory notmandatory moved this to In Progress in BDK Aug 10, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.2 milestone Aug 10, 2023
@nondiremanuel nondiremanuel moved this from In Progress to Needs Review in BDK Aug 22, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladimirfomene vladimirfomene

Labels
None yet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha.2
Development

Successfully merging a pull request may close this issue.

Rename methods of esplora ext vladimirfomene/bdk
3 participants
@notmandatory @vladimirfomene @evanlinjin