Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate fee estimates to allow for arbitrary targets #1052

Closed
tnull opened this issue Aug 1, 2023 · 1 comment
Closed

Interpolate fee estimates to allow for arbitrary targets #1052

tnull opened this issue Aug 1, 2023 · 1 comment
Labels
new feature New feature or request

Comments

@tnull
Copy link
Contributor

tnull commented Aug 1, 2023

As of 0.28.0, BDK's estimate_fee is just handing through individual fee estimates of the underlying Blockchain implementation.

For example in case of the Esplora client, it would just fall back to 1 sat/vb if an unknown target (i.e., not in {1-25, 144, 504, 1008}) is given:

https://github.com/bitcoindevkit/rust-esplora-client/blob/615f76f4256fd8abe95ce76b1fd0d8cf7f81a51a/src/lib.rs#L83-L97

It would be nice to interpolate from the given values rather than silently defaulting to 1sat/vb. If we don't want to interpolate for one reason or another the valid target values should probably be defined as part of a ConfirmationTarget enum, and this behavior should clearly be documented, as it isn't currently.

I can't find estimate_fee in the current master, so not sure what the plans are for BDK 1.0.

@tnull tnull added the new feature New feature or request label Aug 1, 2023
@notmandatory notmandatory added this to BDK Aug 1, 2023
@tnull
Copy link
Contributor Author

tnull commented Aug 1, 2023

Closing as BDK 1.0 won't offer a fee estimation API anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant