Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Remove compiler option to suppress warnings for using experimental unsigned types #11

Closed
thunderbiscuit opened this issue Feb 12, 2022 · 5 comments · Fixed by #17
Closed
Assignees
Milestone

Comments

@thunderbiscuit
Copy link
Member

The following block is no longer necessary as of Kotlin 1.5 (we're currently using 1.6.10):

allprojects {
    tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach {
        kotlinOptions.freeCompilerArgs += "-opt-in=kotlin.ExperimentalUnsignedTypes"
    }
}

See uniffi-rs docs here and related merged PR here for more info.

I can't assign myself but @notmandatory feel free to assign me this one.

@thunderbiscuit thunderbiscuit changed the title Remove annotation suppression for using experimental unsigned types Remove compiler option to suppress warnings for using experimental unsigned types Feb 12, 2022
@artfuldev
Copy link
Contributor

@notmandatory can we add a release target/milestone/version for this?

@artfuldev
Copy link
Contributor

@thunderbiscuit I missed the part about us using a later kotlin version than 1.5 🤦

@thunderbiscuit
Copy link
Member Author

Yes well to be honest I'm not sure it's enforced anywhere, but I think the following block will throw warnings at you if you're using a different version:

buildscript {
    ext.kotlin_version = '1.6.10'
    repositories {
        google()
        mavenCentral()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:7.0.4'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

@notmandatory
Copy link
Member

notmandatory commented Feb 22, 2022

I think it's reasonable to update the README as part of this PR to require Kotlin version 1.6.x.

@notmandatory
Copy link
Member

Fixed by #17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants