nit: No-Auth Options

[carlaKC]

As we're a testing tool, it's possible that people will be running their node without auth (eg for LND - no macaroons).

We should be able to configure and handle this case as it's pretty common in testing.

[bjohnson5]

@carlaKC I do not have the option to assign this to myself, but I will start looking into how to implement this. This will be helpful for running a big network with lots of nodes that do not need authentication.

[bjohnson5]

@carlaKC It looks like the limiting factor here (at least for lnd) is that the tonic_lnd crate does not support creating an RPC client without a macaroon file. The tonic_lnd::connect function requires a valid macaroon path. Any thoughts on how to get around that other than just opening an issue on tonic_lnd?

[carlaKC]

@carlaKC It looks like the limiting factor here (at least for lnd) is that the tonic_lnd crate does not support creating an RPC client without a macaroon file.

Thought this might be the case :( I think we can go ahead an open an issue and perhaps @okjodom can help us out on the fedimint/tonic side 🙏

[bjohnson5]

@carlaKC @okjodom Ok sounds good, I submitted an issue (fedimint/tonic_lnd#21). In the meantime, a workaround is that you can create one macaroon file and use it as a default for all RPC calls. This will satisfy tonic_lnd and if the lnd nodes are using the no-macaroons option they will not check the macaroon anyway.

[carlaKC]

@carlaKC @okjodom Ok sounds good, I submitted an issue (fedimint/tonic_lnd#21). In the meantime, a workaround is that you can create one macaroon file and use it as a default for all RPC calls. This will satisfy tonic_lnd and if the lnd nodes are using the no-macaroons option they will not check the macaroon anyway.

Sounds reasonable to me! Perhaps we can set it up so that we switch in that fake macaroon file if the sim file doesn't specify macaroon so it happens seamlessly(ish) for the end user? Would also be good to nicely catch the error where somebody forgets a macaroon but it's actually required so we can provide a reasonable error message back.