Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging: Log payment summary on info level based on time #128

Closed
carlaKC opened this issue Oct 5, 2023 · 1 comment · Fixed by #141
Closed

Logging: Log payment summary on info level based on time #128

carlaKC opened this issue Oct 5, 2023 · 1 comment · Fixed by #141
Labels
bug Something isn't working feature New feature or request Medium Priority
Milestone
V1 Minor Improvem...

Comments

@carlaKC
Copy link
Contributor

carlaKC commented Oct 5, 2023 •
edited
Loading

Right now we info log a payment summary every 10 payments*. This can get very noisy if we have a lot of payments, or be too quiet if we have too few.

Instead, update logging to log every minute so that we can provide constant feedback to the end user.
@carlaKC carlaKC added feature New feature or request bug Something isn't working Medium Priority labels Oct 5, 2023
@sr-gi
Copy link
Member

sr-gi commented Oct 5, 2023 •
edited
Loading

Right now we info log a payment summary every 10 minutes.

:s/minutes/payments/

@carlaKC carlaKC added this to the V1 Minor Improvements milestone Oct 11, 2023
@carlaKC carlaKC mentioned this issue Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working feature New feature or request Medium Priority
Projects
None yet
Milestone
V1 Minor Improvements
Development

Successfully merging a pull request may close this issue.

sim-lib: Log payment summary every minute for more consistent results carlaKC/sim-ln
2 participants
@sr-gi @carlaKC