Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement secp256k1_ecdsa_signature_serialize and int secp256k1_ecdsa_signature_parse #333

Closed
rustyrussell opened this issue Oct 11, 2015 · 4 comments

Comments

@rustyrussell
Copy link
Contributor

Non-DER versions, which just fill in 64 bits in some canonical order.

Alternately: make the opaque structure a canonical order.

@sipa
Copy link
Contributor

sipa commented Oct 11, 2015 via email

@rustyrussell
Copy link
Contributor Author

Yep, looks good! Please document the serialize format (at a glance, it's 32 byte unsigned BE r value followed by 32 byte unsigned BE s value).

I'd still like a "is_normalized" or "is_canonical" for the s-value test BTW, but I can implement my own with these.

@sipa
Copy link
Contributor

sipa commented Oct 17, 2015 via email

@sipa
Copy link
Contributor

sipa commented Nov 28, 2016

Fixed by #334.

@sipa sipa closed this as completed Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants