Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Lower default of iters to 4 (but keep higher on CI) #1561

Closed
real-or-random opened this issue Jul 1, 2024 · 4 comments · Fixed by #1581
Closed

tests: Lower default of iters to 4 (but keep higher on CI) #1561

real-or-random opened this issue Jul 1, 2024 · 4 comments · Fixed by #1581

Comments

@real-or-random
Copy link
Contributor

real-or-random commented Jul 1, 2024

See discussion at https://gnusha.org/secp256k1/2024-07-01.log, also mentioned in #1549.

@jonasnick
Copy link
Contributor

@sipa said the following in the discussion:

< sipa> i don't think that running at more than 1 has ever actually contributed to a bug being found :p

I don't agree. For example, there are tests that should draw random group elements with an even Y coordinate in one iteration and an odd one in another to test both code paths. Default iteration number of 4 will make 1 in 16 such tests useless.

@sipa
Copy link
Contributor

sipa commented Jul 1, 2024

@jonasnick I don't mean to imply that running with more than 1 iteration doesn't add anything; it clearly adds cases that aren't performed otherwise. I literally meant that I don't think we have ever found an actual bug through those.

@jonasnick
Copy link
Contributor

Should have spelled this out more clearly: I have found bugs during development in code that was only correct if the Y coordinates of random group elements had a specific parity :/

@jonasnick
Copy link
Contributor

See also #1036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants