Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QRCode address in image is not readable #54

Closed
fanquake opened this issue Aug 14, 2020 · 3 comments · Fixed by #71
Closed

QRCode address in image is not readable #54

fanquake opened this issue Aug 14, 2020 · 3 comments · Fixed by #71
Labels
Bug Something isn't working
Milestone
0.21.0

Comments

@fanquake
Copy link
Member

Moved from: bitcoin/bitcoin#19103.

Somehow the resolution of the QRCode image is not high enough.
Native wpkh addresses are non readable and legacy/p2sh addresses are not good readable.
Haven't tested on other OSes than macOS.

Bildschirmfoto 2020-05-29 um 09 52 07

Bildschirmfoto 2020-05-29 um 09 53 21
@fanquake fanquake added the Bug Something isn't working label Aug 14, 2020
@fanquake fanquake mentioned this issue Aug 14, 2020
Closed
@Bosch-0
Copy link

Bosch-0 commented Aug 14, 2020

Same on Windows

image

Not as bad on Linux but could be better

image

@hebasto hebasto mentioned this issue Aug 23, 2020
Merged
@Sjors
Copy link
Member

Sjors commented Aug 28, 2020

Yikes, this looks like a regression; I remember it being far better. Able to reproduce on master on macOS.

@hebasto
Copy link
Member

hebasto commented Aug 28, 2020

@Sjors

Yikes, this looks like a regression; I remember it being far better. Able to reproduce on master on macOS.

Could you point at a version with a nice look?

@jonasschnelli jonasschnelli added this to the 0.21.0 milestone Oct 23, 2020
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

Fix visual quality of text in QR image hebasto/gui
6 participants
@Sjors @jonasschnelli @fanquake @hebasto @Bosch-0 and others