Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example flame graph, to be linked from bitcoin docs. #522

Closed
wants to merge 1 commit into from

Conversation

eklitzke
Copy link

@eklitzke eklitzke commented Mar 9, 2018

I know this seems weird, but I want to host an example flame graph on bitcoincore.org so it can be linked to from the flame graph docs I'm trying to add in this pull request. There is some discussion in that PR, but to summarize:

  • GitHub won't host interactive SVG files (their CDN renders them as a static image)
  • I think having a zoomable, interactive SVG file linked to in my docs makes the demo much more compelling
  • I'd prefer to host the file on an official Bitcoin site rather than my personal domain, mainly because redirecting people to my personal domain seems weird and looks sketchy

See #12649 in github.com/bitcoin/bitcoin for motivation.
@Sjors
Copy link
Member

Sjors commented Mar 12, 2018

Concept ACK. Not sure how to test this.

SVG files are a bit scary because they contain javascript. I don't see anything obviously evil in c45465c at first glance, but it's thousands of lines...

An animated gif seems safer.

@maflcko
Copy link

maflcko commented Mar 22, 2018

bitcoin/bitcoin#12649 was closed

Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@harding
Copy link
Contributor

harding commented Apr 27, 2018

@eklitzke what's the status on this? On the closed upstream PR, you note that you plan to move the documentation to the docs repo, but I assume that doesn't satisfy you problem with GitHub not displaying dynamic SVGs. Do you still want this hosted on BitcoinCore.org?

This basically LGTM. If it's still useful, I'll be happy to pick apart the JS to make sure it doesn't do something awful like mimic our Downloads page and give it a test.

@harding
Copy link
Contributor

harding commented Jun 4, 2018

No response in a month; closing. I'm happy to reopen if discussion resumes.

@harding harding closed this Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants