Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring: enable pylint checks for R0801 #1803

Merged
merged 20 commits into from
Aug 25, 2024
Merged

refactoring: enable pylint checks for R0801 #1803

merged 20 commits into from
Aug 25, 2024

Conversation

Ihor-Pryyma
Copy link
Contributor

Related to #1755

  • enable R0801 (duplicate-code) pylint checks
  • remove code duplicates
  • add test/utils.py and test/constants.py for common functionality

@Ihor-Pryyma Ihor-Pryyma mentioned this pull request Jul 20, 2024
Open
@buhtz
Copy link
Member

buhtz commented Jul 20, 2024

Hello Ihor,
On behalf of the team, thank you for your contribution and taking the time to improve Back In Time. We appreciate it.
Your PR will be reviewed as soon as possible. There is a lot to review so it will take some time.

Best,
Christian

@buhtz buhtz added the PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team. label Jul 20, 2024
@buhtz buhtz added this to the 2nd release from now milestone Jul 20, 2024
buhtz
buhtz requested changes Jul 20, 2024
View reviewed changes
qt/utils.py Outdated Show resolved Hide resolved
common/test/constants.py Outdated Show resolved Hide resolved
common/encfstools.py Show resolved Hide resolved
common/mount.py Outdated Show resolved Hide resolved
common/test/utils.py Outdated Show resolved Hide resolved
qt/logviewdialog.py Outdated Show resolved Hide resolved
qt/logviewdialog.py Outdated Show resolved Hide resolved
qt/settingsdialog.py Outdated Show resolved Hide resolved
qt/settingsdialog.py Outdated Show resolved Hide resolved
common/test/test_restore.py Outdated Show resolved Hide resolved
@Ihor-Pryyma Ihor-Pryyma requested a review from buhtz July 20, 2024 16:15
buhtz
buhtz reviewed Jul 20, 2024
View reviewed changes
common/mount.py Outdated Show resolved Hide resolved
@Ihor-Pryyma Ihor-Pryyma requested a review from buhtz July 21, 2024 12:58
buhtz
buhtz reviewed Jul 21, 2024
View reviewed changes
common/mount.py Outdated Show resolved Hide resolved
common/mount.py Show resolved Hide resolved
common/mount.py Outdated Show resolved Hide resolved
common/mount.py Outdated Show resolved Hide resolved
common/test/utils.py Outdated Show resolved Hide resolved
@buhtz
Copy link
Member

buhtz commented Jul 21, 2024

You might have forgotten to push your latest changes?

@Ihor-Pryyma Ihor-Pryyma force-pushed the refactor/enable-code-duplication-pylint-check branch from d68957c to 6219a46 Compare July 22, 2024 06:36
@buhtz buhtz marked this pull request as draft July 22, 2024 06:43
@buhtz
Copy link
Member

buhtz commented Jul 22, 2024 •
edited
Loading

I set the PR into "Draft" mode to disable TravisCI runs on it. This does save us some "credits" on TravisCI.

EDIT: Seems not to work. It helps if you add "[skip ci]" into the commit messages. Or you collect all commits at your local machine and push them all at once.

@buhtz buhtz added the PR: Modifications requested Maintenance team requested modifications and waiting for their implementation label Jul 22, 2024
@Ihor-Pryyma Ihor-Pryyma force-pushed the refactor/enable-code-duplication-pylint-check branch from 6219a46 to 2e06ca3 Compare July 22, 2024 06:46
@Ihor-Pryyma Ihor-Pryyma requested a review from buhtz July 22, 2024 11:34
buhtz
buhtz requested changes Jul 22, 2024
View reviewed changes
common/test/test_config_crontab.py Outdated Show resolved Hide resolved
common/test/utils.py Outdated Show resolved Hide resolved
common/test/utils.py Outdated Show resolved Hide resolved
@Ihor-Pryyma Ihor-Pryyma requested a review from buhtz July 26, 2024 11:29
@Ihor-Pryyma Ihor-Pryyma force-pushed the refactor/enable-code-duplication-pylint-check branch from ee85861 to ed3d40d Compare August 1, 2024 12:58
@Ihor-Pryyma Ihor-Pryyma marked this pull request as ready for review August 1, 2024 12:58
@buhtz
Copy link
Member

buhtz commented Aug 1, 2024

Hello Ihor,
I haven't forgotten you. All PRs are blocked currently until our release 1.5.1 reach the Debian unstable repo and after that the Ubuntu repo. This should be finished until August 15th when Ubuntu does reach its Debian Import Freeze.

buhtz
buhtz reviewed Aug 11, 2024
View reviewed changes
Copy link
Member

@buhtz buhtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Ihor,
I merge some PRs and because of that solved some merge conflicts in your branch. So update your local branch.

common/test/test_config_crontab.py Outdated
profile1.snapshots.rsync_options.value=
profiles.version=1
''')
config_data = """
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain me the advantage of this solution compared to the previous one?

@buhtz buhtz removed the PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team. label Aug 11, 2024
@buhtz buhtz self-assigned this Aug 11, 2024
@buhtz buhtz merged commit e90ce00 into bit-team:dev Aug 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buhtz buhtz buhtz approved these changes

Assignees

@buhtz buhtz

Labels
PR: Modifications requested Maintenance team requested modifications and waiting for their implementation
Projects
None yet
Milestone
1.5.3 (Upcoming release)
Development

Successfully merging this pull request may close these issues.
2 participants
@Ihor-Pryyma @buhtz