Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include an option to prevent offers from being taken by non-signed accounts #133

Closed
mpolavieja opened this issue Nov 3, 2019 · 13 comments
Closed

Comments

@mpolavieja
Copy link

mpolavieja commented Nov 3, 2019

This is a Bisq Network proposal. Please familiarize yourself with the submission and review process.

Problem description

It should be obvious that new users that come to Bisq to buy 0,25 BTC or more don´t really want to make 25 or more transactions as that would be prohibitively expensive and time consuming. If those users I am referring to are posting offers to buy 0,01 BTC, it is very likely that they post them in order to get their account signed.

If their offers are taken repeteadly by non signed accounts, that could be quite frustrating. It could be a rather serious onboarding barrier as it would be a waste of time and fees for the new user. Moreover, having a lot of undesired small transactions might be also an issue with the bank. Might be too noisy.

Suggested solution

Provide the option to makers to restrict their offers so they can only be taken by signed accounts. The risk of siloing liquidity amongst old users is very low, as it is unlikely that old signed users post offers as low as 0,01 BTC to trade only with signed accounts. And if old users restrict their sell offers of 0.06, 0.12 or 0.25 BTC, the buyers that have the limits to take those offers are probably already signed, specially on the long run.

I suggest to include this option as a checkbox in the "Create Offer" screen and that it is always unchecked by default if the account is already signed. If the account with which the offer is being created is unsigned, I am not sure if it should be checked by default. If it is checked by default it will make things easier for the new user. If it is unchecked by default, a pop up would be necessary to explain the user that he can check that checkbox if he wants to get his account signed quicker (not to waste time and fees).

@mpolavieja mpolavieja changed the title Include an option to restrict offers from being taken by non-signed accounts Include an option to prevent offers from being taken by non-signed accounts Nov 4, 2019
@ripcurlx
Copy link

ripcurlx commented Nov 4, 2019

If it is enabled by default it will make things easier for the new user.

The only risk for newbies would be, is that this checkbox might be checked forever. Maybe if we check it by default we have to additionally let the user choose in the "you got signed"-popup, if we should deactivate this setting again.

@mpolavieja
Copy link
Author

this checkbox might be checked forever.

My suggestion is that the checkbox would be checked by default only if the acount with which the offer is being created is an unsigned account. Otherwise it would be always unchecked. (maybe the confusion is that I used the words "enabled" / "disabled" instead of checked / unchecked, I´ll ammend that.)

@mpolavieja
Copy link
Author

Would it be a good idea to enable this checkbox only for buy offers with insecure payment methods? The checkbox would not be even available for BTC sell offers, so it doesn´t play as a barrier in any case?

The only downside I am able to see is that if it is checked by default for unsigned accounts, new users that only want to test and play around with Bisq doing small real trades should be aware of this so they know they have to uncheck the box when creating the offer.

As a more general thought, I am of the opinion that from a security point of view this kind of protection, if implemented, should be for the BTC sellers which are the ones that bear the most risk when accepting fiat, but for the sake of bootstrapping and being as less disruptive as possible, I suggest to use this option very specifically (at least initially) to make the signing process less painful for newbies.

@sqrrm
Copy link
Member

sqrrm commented Nov 5, 2019

I think it would be ok to have it there for both buy and sell offers for unsigned accounts as accounts get signed in both directions. But then you already get that filter implicitly when selling if selling more than 0.01 BTC.

@mpolavieja
Copy link
Author

As @flix1 suggested during yesterday´s call, a very good an easy workaround for this problem is to post very small offers, like selling 0,0001 BTC.

The only drawback of doing it this way is that the signer would need a huge premium over the market if he wants to cover his costs. So market incentives for seed signers are a bit better if this is possible to do it with 0.01 BTC and restricting signed accounts.

In any case, as Félix suggested, we should encourage those who are willing to collaborate by signing new accounts to use this suggestion to improve chances that his offers are only taken by unsigned accounts. (Cautioning also not to sign too many accounts so the trust tree is not too narrow, and always remembering to delay the release of the funds as much as possible).

@ripcurlx
Copy link

Shouldn't a web of trust keep out unknown elements? Perhaps KYC?

As I assume this is a sarcastic comment: 🤔 Yes, we could just prevent anyone else to join the web of trust, that would keep it safe for sure.

@mpolavieja
Copy link
Author

@ripcurlx, @sqrrm and everyone else. Is this worth implementing or should I close it as stalled?

@sqrrm
Copy link
Member

sqrrm commented Jan 23, 2020

I would say it's low priority. Ok for me to close as stalled.

@mpolavieja
Copy link
Author

Closed as stalled / low priority

@mpolavieja
Copy link
Author

@sqrrm , I have had a conversation regarding onboarding new users within the scope of growth plans. The problem of signed users taking 0,01 BTC sell offers still remains. I am reopening this issue wo we can discuss it again. Maybe If the development effort is not big, it might be worth including it as a priority.

See also the concerns raised by @cbeams here: bisq-network/projects#10

@sqrrm
Copy link
Member

sqrrm commented Mar 9, 2020

Yes, it's one of my top priorities. I haven't been able to do much development lately so I had to focus on even more urgent issues. It's not forgotten.

@MwithM
Copy link

MwithM commented Aug 17, 2020

Is this on a to-do list? Let me know if it is and I'll close as approved.

@MwithM
Copy link

MwithM commented Sep 21, 2020

Closed as stalled. Not a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@ripcurlx @mpolavieja @sqrrm @MwithM and others