For Cycle 23

[wallclockbuilder]

Summary

• BSQ requested: 283.49
• USD requested: 618.00
• BSQ rate: 2.18 USD per BSQ

Contributions delivered

Cycle 23

Title	Team	USD	Link	Notes
Replace slack with Keybase	dev	5	5288	PR
Release v1.6.0	dev	441	Report	Testing
Release v1.6.1	dev	0	Report	Testing
Improve takeoffer error handing	dev	17	5294	Code Review
Fix dark mode readibility of specific texts - Part 2	dev	7	5332	Code Review
Delete issue template file	dev	0	5353	Code Review
Remove the apparent link for cases where the trade is not available for mediators	dev	37	5354	Code Review
Add api method createcryptopaymentacct	dev	28	5356	Code Review
Allow default fee values in leniency check	dev	21	5365	Code Review
Fix NPE in Portfolio View when market price n/a	dev	31	5385	Code Review
Update commands for mediator/refund agent	dev	22	5323	Merged PR
Fix typo in function name	dev	9	5291	Merged PR
Replace slack with Keybase	dev	0	5288	Merged PR
Transaction Details dialog should display exact amount of BTC sent. No more. No less.	dev	0	5305	Issue leading to Merged PR

Contributions in progress

Title	Team	USD	Link	Notes
Update testing steps.	dev	-	5317	-
Change file mentioned to from .desktop to .service	dev	-	5319	-
Generate more than 1 block(regtest)	dev	-	5355	-
Add tooltip(on hover) to BondUnlockTime column title	dev	-	5275	-
Temporary solution for high mining fees	dev	-	5282	-
Publish ALL pending offers when mining fee is low.	dev	-	5296	-
Unhide custom mining fee option(from settings-page to send-bitcoin-page)	dev	-	5298	-
Unhide custom mining fee option for sending BSQ	dev	-	5304	-
Let user enter human friendly time for locking up BSQ. Let Bisq handle the conversion to block time.	dev	-	5306	-

[ghost]

Info

Read BSQ amount from summary: 497.2477064
Read USD amount from summary: 1084
Read BSQ rate from summary: 2.18
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":564}
Parsed lineitem: {"team":"dev","amount":128}
Parsed lineitem: {"team":"dev","amount":17}
Parsed lineitem: {"team":"dev","amount":7}
Parsed lineitem: {"team":"dev","amount":3}
Parsed lineitem: {"team":"dev","amount":87}
Parsed lineitem: {"team":"dev","amount":128}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":31}
Parsed lineitem: {"team":"dev","amount":22}
Parsed lineitem: {"team":"dev","amount":9}
Parsed lineitem: {"team":"dev","amount":39}
Parsed lineitem: {"team":"dev","amount":25}

Errors

ERROR: Total USD does not match the sum of line items:

• Summary total: 1084.00 USD
• Calculated total: 1086.00 USD

[ripcurlx]

@wallclockbuilder Please don't create test scripts on your own for new releases, as it leads to unnecessary testing cycles. In this case you were testing for v1.6.1 account creation, but the changes in the release https://github.com/bisq-network/bisq/releases/tag/v1.6.1 didn't touch this part of the code at all. The amount for release testing of v1.6.0 also seems to be higher than what we compensated in the past for this work.

Thanks for doing code reviews as well, but here are a couple of remarks to your reviews. I think if you leave an ACK or utACK at a PR it would be good to add what you tested or reviewed in more detail. Otherwise it is quite hard to evaluate without some track record in the project if the compensation request asked for does match your review work.

• Add api method createcryptopaymentacct bisq#5356: Why was the code review for this PR so much more effort?
• Delete issue template file bisq#5353: What did you ACK or tested? (only a file was deleted in this PR)
• Remove the apparent link for cases where the trade is not available for mediators bisq#5354: In this case where the review amount exceeds the amount of the contribution I think the amount is out of proportion.

Looking at bisq-network/bisq#5288 an other CRs I don't think this amount requested is just.

bisq-network/bisq#5305: We very rarely accepted the issue creation for compensation in the past and only if there was extensive testing back and forth between developers and reporters.

[wallclockbuilder]

• 5356: Setup time required to switch into API enduser context. Being a first time user(tester), there were some sunk costs in setup time. This setup will not need to be done again for other tests.
• 5353 Adjusted the number. Should have been a utACK.
• 5354Testing required switching into contributor's context. To get there meant running alice, bob, and mediator instances, alice creating an offer, bob taking the offer, alice opening a mediation, before testing the interface. Contributor already had this context setup so makes sense it took him/her less time.
• 5288 I've adjusted that.
• 5305 Adjusted.

[ghost]

Info

Read BSQ amount from summary: 497.2477064
Read USD amount from summary: 1086
Read BSQ rate from summary: 2.18
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":564}
Parsed lineitem: {"team":"dev","amount":128}
Parsed lineitem: {"team":"dev","amount":17}
Parsed lineitem: {"team":"dev","amount":7}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":87}
Parsed lineitem: {"team":"dev","amount":128}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":31}
Parsed lineitem: {"team":"dev","amount":22}
Parsed lineitem: {"team":"dev","amount":9}
Parsed lineitem: {"team":"dev","amount":12}
Parsed lineitem: {"team":"dev","amount":25}

Errors

ERROR: Total USD does not match the sum of line items:

• Summary total: 1086.00 USD
• Calculated total: 1056.00 USD

[ghost]

Info

Read BSQ amount from summary: 497.2477064
Read USD amount from summary: 1056
Read BSQ rate from summary: 2.18
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":564}
Parsed lineitem: {"team":"dev","amount":128}
Parsed lineitem: {"team":"dev","amount":17}
Parsed lineitem: {"team":"dev","amount":7}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":87}
Parsed lineitem: {"team":"dev","amount":128}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":31}
Parsed lineitem: {"team":"dev","amount":22}
Parsed lineitem: {"team":"dev","amount":9}
Parsed lineitem: {"team":"dev","amount":12}
Parsed lineitem: {"team":"dev","amount":25}

Errors

ERROR: Total BSQ does not match the sum of line items:

• Summary total: 497.25 BSQ
• Calculated total: 484.40 BSQ

[ghost]

Info

Read BSQ amount from summary: 484.4
Read USD amount from summary: 1056
Read BSQ rate from summary: 2.18
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":564}
Parsed lineitem: {"team":"dev","amount":128}
Parsed lineitem: {"team":"dev","amount":17}
Parsed lineitem: {"team":"dev","amount":7}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":87}
Parsed lineitem: {"team":"dev","amount":128}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":31}
Parsed lineitem: {"team":"dev","amount":22}
Parsed lineitem: {"team":"dev","amount":9}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}

Errors

ERROR: Total USD does not match the sum of line items:

• Summary total: 1056.00 USD
• Calculated total: 1019.00 USD

[ghost]

Info

Read BSQ amount from summary: 408.72
Read USD amount from summary: 891
Read BSQ rate from summary: 2.18
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":564}
Parsed lineitem: {"team":"dev","amount":128}
Parsed lineitem: {"team":"dev","amount":17}
Parsed lineitem: {"team":"dev","amount":7}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":87}
Parsed lineitem: {"team":"dev","amount":128}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":31}
Parsed lineitem: {"team":"dev","amount":22}
Parsed lineitem: {"team":"dev","amount":9}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}

Errors

ERROR: Total USD does not match the sum of line items:

• Summary total: 891.00 USD
• Calculated total: 1019.00 USD

[wallclockbuilder]

• Release v1.6.1 Adjusted to 0.

[wallclockbuilder]

The testing is in the ball park of the most recent tests approved. Mine is a few percentage points higher only because I'm a first timer. It'll get lower as I do more rounds.

[ripcurlx]

• 5356: Setup time required to switch into API enduser context. Being a first time user(tester), there were some sunk costs in setup time. This setup will not need to be done again for other tests.

5354Testing required switching into contributor's context. To get there meant running alice, bob, and mediator instances, alice creating an offer, bob taking the offer, alice opening a mediation, before testing the interface. Contributor already had this context setup so makes sense it took him/her less time.

As we don't want to incentivize time spent, but rather what is delivered it would be great to keep out of your testing and review efforts anything that is related to one-time setup efforts. So it is easier to review for everyone who is checking CRs without the need to know if someone is already around for a long time or new to Bisq.

[wallclockbuilder]

Will do!

[ghost]

Info

Read BSQ amount from summary: 385.78
Read USD amount from summary: 741
Read BSQ rate from summary: 2.18
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":564}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":17}
Parsed lineitem: {"team":"dev","amount":7}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":37}
Parsed lineitem: {"team":"dev","amount":28}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":31}
Parsed lineitem: {"team":"dev","amount":22}
Parsed lineitem: {"team":"dev","amount":9}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}

Errors

ERROR: Total BSQ does not match the sum of line items:

• Summary total: 385.78 BSQ
• Calculated total: 339.91 BSQ

[wallclockbuilder]

5354: Adjusted from 128 to 28
5356: Adjusted from 87 to 37

[wallclockbuilder]

@ripcurlx All issues addressed. Ready for review.

[MwithM]

The proposal phase time has concluded, you will have to resubmit this for next cycle. It would be nice if you finally get it approved though. You can keep the review even if the issue is closed.

Closed as not submitted.

[wallclockbuilder]

Alright

[ripcurlx]

Alright

Sorry about this delayed reviews. I had and have still personal issues that consumed most of my time over the last week. I'll do another proper review of the changes on Monday. Sorry that you missed because of this the chance to submit your CR for this cycle.