Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 18 #692

Closed
cd2357 opened this issue Oct 23, 2020 · 8 comments
Closed

For Cycle 18 #692

cd2357 opened this issue Oct 23, 2020 · 8 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@cd2357
Copy link

cd2357 commented Oct 23, 2020

Summary

  • BSQ requested: 1470.58
  • USD requested: 1000 USD
  • BSQ rate: 0.68 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 17 #666

Contributions delivered

Title Team USD Link Notes
Update tor-binary build process to allow tor binary hash verification notes-1
Update tor-binary and netlayer versions to use tor binaries from latest tor browser v10 notes-2
dev 1000 bisq-network/bisq#4604 Total for items above

notes-1

  • tor-binary: Update maven config to use published SHA-512 binary hashes, instead of generated (then manually compared) hashes. This resulted in commit cd2357/tor-binary@f3bc31f
  • netlayer: Create a build based on the above tor-binary (cd2357/netlayer@cdbe476)
  • Bisq: test if desktop app accepts new binaries

notes-2

Contributions in progress

@cd2357 cd2357 changed the title [WIP] For Cycle 18 For Cycle 18 Oct 24, 2020
@ghost ghost added the parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid label Oct 24, 2020
@ghost
Copy link

ghost commented Oct 24, 2020

Info

Read BSQ amount from summary: NaN
Read USD amount from summary: NaN
Read BSQ rate from summary: 0.68
Parsed lineitem: {"team":"dev","amount":1000}

Errors

Unknown team specified: ---
Invalid amount specified: ---:
Tableformat: request lineitem #1 did not pass validation.
Unknown team specified:
Tableformat: request lineitem #2 did not pass validation.
Unknown team specified:
Tableformat: request lineitem #3 did not pass validation.

@ghost ghost added the team:dev https://bisq.wiki/Dev_Team label Oct 24, 2020
@ghost
Copy link

ghost commented Oct 24, 2020

Info

Read BSQ amount from summary: 1470.58
Read USD amount from summary: 1000
Read BSQ rate from summary: 0.68
Parsed lineitem: {"team":"dev","amount":1000}

Errors

Unknown team specified: ---
Invalid amount specified: ---:
Tableformat: request lineitem #1 did not pass validation.
Unknown team specified:
Tableformat: request lineitem #2 did not pass validation.
Unknown team specified:
Tableformat: request lineitem #3 did not pass validation.

@ghost
Copy link

ghost commented Oct 24, 2020

Info

Read BSQ amount from summary: 1470.58
Read USD amount from summary: 1000
Read BSQ rate from summary: 0.68
Parsed lineitem: {"team":"dev","amount":950}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":1000}

Errors

Unknown team specified: ---
Invalid amount specified: ---:
Tableformat: request lineitem #1 did not pass validation.
ERROR: Total USD does not match the sum of line items:

  • Summary total: 1000.00 USD
  • Calculated total: 2000.00 USD

@ghost
Copy link

ghost commented Oct 24, 2020

Info

Read BSQ amount from summary: 1470.58
Read USD amount from summary: 1000
Read BSQ rate from summary: 0.68
Parsed lineitem: {"team":"dev","amount":1000}

Errors

Unknown team specified: ---
Invalid amount specified: ---:
Tableformat: request lineitem #1 did not pass validation.

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Oct 24, 2020
@MwithM MwithM added this to the Cycle 18 milestone Oct 25, 2020
@ripcurlx
Copy link
Contributor

As stand in team lead for dev I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@cd2357
Copy link
Author

cd2357 commented Oct 26, 2020

Tx ID: cf7fe4e298fdd9bc3010a8b033a5dd8bfde9c6658faa0d5475ab97e76a5d27ad

@ghost
Copy link

ghost commented Nov 8, 2020

Issuance by Team:

team amount BSQ amount USD
dev 1470.58 1000.00

Total Issuance: 1470.58 BSQ (equivalent to: 1000.00 USD)

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Nov 8, 2020
@MwithM
Copy link
Contributor

MwithM commented Nov 8, 2020

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants