Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Cycle 14 #588

Closed
dmos62 opened this issue Jun 17, 2020 · 9 comments
Closed

For Cycle 14 #588

dmos62 opened this issue Jun 17, 2020 · 9 comments
Assignees
@ripcurlx
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone
Cycle 14

Comments

@dmos62
Copy link

dmos62 commented Jun 17, 2020 •
edited
Loading

Summary

Contributions delivered

Title Team USD Link Notes
Bugfixes related to switch statements dev 50 bisq-network/bisq#4250
Changes to local BTC node reminder in Settings > Network info dev 0 bisq-network/bisq#4024
Secondary sort order for offer book (rewrite) dev 60 bisq-network/bisq#4259
Add local Bitcoin node configuration detection dev 80 bisq-network/bisq#3982 This PR introduces a new feature and refactors; the next PR reverts the feature introduced by the last, so that only the refactoring is left; requesting compensation for the refactoring.
Revert to only check local BTC node's port dev 0 bisq-network/bisq#4067 Check previous note.
dev 80 bisq-network/bisq#4168 Minor reviews:
dev 0 bisq-network/bisq#4193
dev 0 bisq-network/bisq#4295
dev 0 bisq-network/bisq#4296

Contributions in progress

Reviews of:

Project on hold: bisq-network/projects#30
@MwithM
Copy link
Contributor

MwithM commented Jun 17, 2020

Tomorrow is the deadline to submit compensation requests. Please complete this and remove the [WIP] tag.

@dmos62 dmos62 changed the title [WIP] For Cycle 14 For Cycle 14 Jun 18, 2020
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Jun 18, 2020
@dmos62
Copy link
Author

dmos62 commented Jun 18, 2020

@MwithM ready for review.

@MwithM MwithM added this to the Cycle 14 milestone Jun 18, 2020
@sqrrm
Copy link
Member

sqrrm commented Jun 21, 2020

As stand in dev team lead that forgot this is part of the duty I approve this request.

Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@ripcurlx
Copy link
Contributor

@sqrrm Thanks for reviewing this cycle again as you are more familiar with the PRs merged in this cycle!

Still, as stand in dev team lead I approve this request.

@MwithM
Copy link
Contributor

MwithM commented Jun 23, 2020

Hey @dmos62 don't forget to submit your compensation to the DAO and comment here the TXID.

@dmos62
Copy link
Author

dmos62 commented Jun 24, 2020

TXID: 3f915a2d308ce1d5a94ef809513f7a9e4bc3264834efcac309f19936c8771425

@MwithM thanks for the reminder.

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Jul 2, 2020
@ghost
Copy link

ghost commented Jul 2, 2020

Issuance cannot be displayed as there were errors in the comp request

@MwithM
Copy link
Contributor

MwithM commented Jul 2, 2020

Closed as: accepted

@MwithM MwithM closed this as completed Jul 2, 2020
@ghost
Copy link

ghost commented Jul 2, 2020

Issuance by Team:

team amount
DEV 428.00 BSQ

Total Issuance: 428.00 BSQ (equivalent to: 270.00 USD)

@dmos62 dmos62 mentioned this issue Jul 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripcurlx ripcurlx

Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Request Board
Archived in project
Milestone
Cycle 14
Development

No branches or pull requests
4 participants
@ripcurlx @dmos62 @sqrrm @MwithM