Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default toolchain to Java 22 #2989

Open
rodvar opened this issue Nov 8, 2024 · 0 comments
Open

Default toolchain to Java 22 #2989

rodvar opened this issue Nov 8, 2024 · 0 comments

Comments

@rodvar
Copy link
Contributor

rodvar commented Nov 8, 2024

Follow up after merged PR -> #2965 (review)

  • We use Java 17 but we would like to use Java 22 for the Bisq 2 app build/deployment. For publishing for mobile though we need java 17. It should be made default Java 22 and the publish task change it for the time it is running to Java 17. We should also rename the publishAll task to specify the special purpose for Bisq mobile (requiring Java 17).
  • The Bisq verison in libs.versions.toml should be dynamically set from the root version
  • Jitpack not used yet. Need to be figured out if we want to use it. For now we use MavenLocal

Important notes to develop a contribution for this issue

  • ./gradlew publishAll needs to publish all jars to your maven local repo (~/.m2/repository) using Java 17
  • assemble, build, install related task for release of bisq desktop should use Java 22 (see ./gradlew buildAll to understand which ones are involved)
  • Ideally search in the code where the toolchain is set and default to 22 (instead of current 17) adding a mechanism to use J17 for jar publishing
  • Finally, it would be great if we could publish J17 jars also to a public repo (like jitpack)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants