Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a new key for settings badge. #6085

Merged
merged 1 commit into from Mar 3, 2022
Merged

Use a new key for settings badge. #6085

merged 1 commit into from Mar 3, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 3, 2022

  • Rename the key constant variable to SETTINGS_BADGE_KEY to clarify that its value should be different each time it is used for a new feature.
  • Use a key which describes the new feature being promoted.

image

Use a new key for settings badge.
8fa44d7 
Rename the key constant variable to SETTINGS_BADGE_KEY to clarify
that its value should be different each time it is used for a new
feature.
Use a key which describes the new feature being promoted.
ripcurlx
ripcurlx approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.8.4 milestone Mar 3, 2022
@ripcurlx ripcurlx merged commit c4a941c into bisq-network:master Mar 3, 2022
@ghost ghost deleted the 5396_privacy_enhancement branch October 18, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.4
Development

Successfully merging this pull request may close these issues.
1 participant
@ripcurlx