From 7e7dce74076050e764bac62de2d644983b01aae8 Mon Sep 17 00:00:00 2001 From: wiz Date: Fri, 6 Nov 2020 14:23:44 +0900 Subject: [PATCH 1/2] Remove HitBTC as a pricenode data provider Recently, some Monero traders were complaining the XMR/BTC price on the Bisq Price Index was off from most exchanges. Indeed, it seems HitBTC is trading at a -10% divergence for some reason, I guess they have low liquidity or some other reason, but after taking a look we are currently using HitBTC for the following assets: * AEON - only 2 trades ever, last traded March 2019 * EMC - never traded * GRIN - looks like only fake trades, last traded Jan 2019 * PART - only 7 trades ever, last traded August 2020 * XRC - last traded December 2019 * XMR - obviously very important for Bisq So I feel it's worth it to drop HitBTC as a data provider from Bisq to make the Monero traders happy and make the Monero price more accurate. --- .../bisq/price/spot/providers/Hitbtc.java | 46 ------------------- 1 file changed, 46 deletions(-) delete mode 100644 pricenode/src/main/java/bisq/price/spot/providers/Hitbtc.java diff --git a/pricenode/src/main/java/bisq/price/spot/providers/Hitbtc.java b/pricenode/src/main/java/bisq/price/spot/providers/Hitbtc.java deleted file mode 100644 index cd98cff1732..00000000000 --- a/pricenode/src/main/java/bisq/price/spot/providers/Hitbtc.java +++ /dev/null @@ -1,46 +0,0 @@ -/* - * This file is part of Bisq. - * - * Bisq is free software: you can redistribute it and/or modify it - * under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or (at - * your option) any later version. - * - * Bisq is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public - * License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with Bisq. If not, see . - */ - -package bisq.price.spot.providers; - -import bisq.price.spot.ExchangeRate; -import bisq.price.spot.ExchangeRateProvider; - -import org.knowm.xchange.hitbtc.v2.HitbtcExchange; - -import org.springframework.stereotype.Component; - -import java.time.Duration; - -import java.util.Set; - -@Component -class Hitbtc extends ExchangeRateProvider { - - public Hitbtc() { - super("HITBTC", "hitbtc", Duration.ofMinutes(1)); - } - - @Override - public Set doGet() { - // Supported fiat: USD - // Supported alts: AEON, BTM, DASH, DCR, DOGE, EMC, ETC, ETH, GRIN, LTC, NAV, - // PART, XMR, XRC, XZC, ZEC, ZEN - return doGet(HitbtcExchange.class); - } - -} From 4959db87e3bf194382e05f775f5d6a445dddee29 Mon Sep 17 00:00:00 2001 From: wiz Date: Fri, 6 Nov 2020 23:47:19 +0900 Subject: [PATCH 2/2] Remove test cases for HitBTC pricenode data provider class --- .../bisq/price/spot/providers/HitbtcTest.java | 34 ------------------- 1 file changed, 34 deletions(-) delete mode 100644 pricenode/src/test/java/bisq/price/spot/providers/HitbtcTest.java diff --git a/pricenode/src/test/java/bisq/price/spot/providers/HitbtcTest.java b/pricenode/src/test/java/bisq/price/spot/providers/HitbtcTest.java deleted file mode 100644 index 0d70e427225..00000000000 --- a/pricenode/src/test/java/bisq/price/spot/providers/HitbtcTest.java +++ /dev/null @@ -1,34 +0,0 @@ -/* - * This file is part of Bisq. - * - * Bisq is free software: you can redistribute it and/or modify it - * under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or (at - * your option) any later version. - * - * Bisq is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public - * License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with Bisq. If not, see . - */ - -package bisq.price.spot.providers; - -import bisq.price.AbstractExchangeRateProviderTest; - -import lombok.extern.slf4j.Slf4j; - -import org.junit.jupiter.api.Test; - -@Slf4j -public class HitbtcTest extends AbstractExchangeRateProviderTest { - - @Test - public void doGet_successfulCall() { - doGet_successfulCall(new Hitbtc()); - } - -}