Fix address validation for whitespace after comma #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typical comma separated values have a space after each comma in order to make the list more human-readable. In some areas of bisq, comma separated lists are generated this way (see #4203), but the validation of comma separated addresses was not accepting spaces after commas. This change to the regex allows optional whitespace after comma separators. A new test has been added to validate the scenario of whitespace after comma. Fixes #4203
ghost
mentioned this pull request
|
👍 utACK |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typical comma separated values have a space after each comma in order to make the list more human-readable. In some areas of bisq, comma separated lists are generated this way (see #4203), but the validation of comma separated addresses was not accepting spaces after commas. This change to the regex allows optional whitespace after comma separators. A new test has been added to validate the scenario of whitespace after comma.
Fixes #4203
Before
After