Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user experience once mediation has been accepted by both parties #5546

Closed
pazza83 opened this issue May 31, 2021 · 1 comment · Fixed by #5870
Closed

Improve user experience once mediation has been accepted by both parties #5546

pazza83 opened this issue May 31, 2021 · 1 comment · Fixed by #5870

Comments

@pazza83
Copy link

pazza83 commented May 31, 2021

Description

When mediation for a given trade is accepted by both parties the trade moves from 'open trades' to 'history' and the payout transaction ID is broadcast.

This is how it should be but the user experience could be achieved by keeping the trade in 'open trades' for longer and give the user the option to withdraw funds to Bisq wallet or external wallet. This would add an additional step that is the same as what happens currently when trades in 'open trades' are successfully completed ie, the user is notified and then they make the choice to keep funds in Bisq wallet or withdraw them. This would improve the user experience consistency.

Version

v 1.6.5

Steps to reproduce

From the perspective of 'Trader 1 (initial trader to accept mediation)'

A trade goes to mediation.

  1. Trader 1 accepts mediation proposal.
  2. Trader 2 accepts mediation proposal.

Trader 1 is not informed mediation has been accepted, there is no notification. Next time they log in the trade will have moved from open trades to history and the broadcast payout tx id will hopefully have been paid out. Trader 1 will need to check funds > transactions to see the status of the trade.

From the perspective of 'Trader 2 (second trader to accept mediation)'

A trade goes to mediation.

  1. Trader 1 accepts mediation proposal.
  2. Trader 2 accepts mediation proposal.

Trader 2 is not informed mediation has been accepted, there is no notification. The trade will have moved from open trades to history and the payout tx id will be broadcast.

Expected behaviour

From the perspective of 'Trader 1 (initial trader to accept mediation)'

A trade goes to mediation.

  1. Trader 1 accepts mediation proposal.
  2. Trader 2 accepts mediation proposal.

Trader 1 is not informed mediation has been accepted, there is a notification. The mediated trade will still be in open trades and the Trader 1 will have the option to keep the funds in their Bisq wallet or withdraw to an external wallet. The trade will then move to history.

From the perspective of 'Trader 2 (second trader to accept mediation)'

A trade goes to mediation.

  1. Trader 1 accepts mediation proposal.
  2. Trader 2 accepts mediation proposal.

Trader 2 is informed mediation has been accepted, by a notification. The trade will still be in open trades and Trader 2 will have the option to keep the funds in their Bisq wallet or withdraw to an external wallet. The trade will then move to history.

@pazza83
Copy link
Author

pazza83 commented Sep 23, 2021

Hi @xyzmaker123 let me know if you would like to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants