Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Western Union Payment Method to be Multi-Currency #5498

Closed
pazza83 opened this issue May 16, 2021 · 7 comments
Closed

Change Western Union Payment Method to be Multi-Currency #5498

pazza83 opened this issue May 16, 2021 · 7 comments

Comments

@pazza83
Copy link

pazza83 commented May 16, 2021

Description

Western Union supports multiple currencies.

Currently when adding Western Union as a payment method to Bisq it requires you to select only one currency.

Sending payments to people in multiple other currencies is what Western Union is for.

The Western Union payment method in Bisq should be updated to included ALL currencies, barring the ones listed below.

Version

1.6.4

Steps to reproduce

Go to Accounts > National Currency Accounts

Select Add New Account, choose Western Union

You will be required to select only one currency.

Expected behaviour

Go to Accounts > National Currency Accounts

Select Add New Account, choose Western Union

You will be required to select out of all currencies available.

Screenshots

This is how it currently is:

WU

You should have the option to select multiple currencies from a list of all currencies available in Bisq. The only currencies NOT supported by Western Union are as follows:

  • Iran (IRN)
  • North Korea (PRK)
  • Syria (SYR)
  • Sudan (SDN)
  • Cuba (CUB)
@BtcContributor
Copy link
Contributor

Hi @pazza83,
I can handle this issue.

@BtcContributor
Copy link
Contributor

BtcContributor commented May 17, 2021

@pazza83 should we also entirely delete the "Select region" and "Select country" dropdown menu?

Not sure how they could help, I think it is a useless information if we enable all currencies for all users unless these are useful from a recipient perspective.

@pazza83
Copy link
Author

pazza83 commented May 19, 2021

@pazza83 should we also entirely delete the "Select region" and "Select country" dropdown menu?

Yes

Not sure how they could help, I think it is a useless information if we enable all currencies for all users unless these are useful from a recipient perspective.

I agree it is useless information. The trade currency will be determined by what fiat/BTC pair the offer is placed. So "Select region" and "Select country" dropdowns are not needed.

@BtcContributor
Copy link
Contributor

@ripcurlx I don't have much time to dedicate to dev right now unfortunately and this is taking me more time that I anticipated so I don't want to slow things down more than this

Please assign this issue to someone else, thanks!

@pazza83
Copy link
Author

pazza83 commented Jun 20, 2021

Thanks @BtcContributor for letting us know. Is any other @bisq-network/bisq-devs able to take this on?

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants