Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors while opening DAO proposal links on Windows #5261

Closed
BtcContributor opened this issue Mar 2, 2021 · 4 comments · Fixed by #5262
Closed

Errors while opening DAO proposal links on Windows #5261

BtcContributor opened this issue Mar 2, 2021 · 4 comments · Fixed by #5262

Comments

@BtcContributor
Copy link
Contributor

Description

When trying to open a DAO proposal link on Windows, the file explorer is wrongly opened instead of the browser due to the fact that the URL is not surrounded by double quotes.

bisq9

Everything is working fine on MacOS and Ubuntu (just tested).

Version

1.5.8

@pazza83
Copy link

pazza83 commented Mar 6, 2021

Hi @BtcContributor thanks for picking this up.

The issue is also appearing on:

  • Settings > about
  • DAO > Bonding > Bonded roles
  • DAO > Governance > Vote results (name / link)
    and proposal info screens when clicked on in 'Proposals' and 'Vote results'

@BtcContributor
Copy link
Contributor Author

BtcContributor commented Mar 6, 2021

Thanks, I will take a look.

My fix already handle those cases @pazza83.

@pazza83
Copy link

pazza83 commented Mar 10, 2021

Hi @BtcContributor is this issue raised on Bisq also relate to your fix? https://bisq.community/t/how-to-make-bisq-open-bitcoin-core-as-it-used-to-until-recently/10546

The user cannot create a GitHub issue so if it fixes it I will let them know

@BtcContributor
Copy link
Contributor Author

@pazza83 yes, this should fix also that issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants