A new mediation resolution doesn't reset the trader's choices

[huey735]

Description

When, for some reason, a mediator needs to make a second resolution suggestion, the trader that accepted the first one doesn't get to reject the second suggestion.

Version

1.5.5

Steps to reproduce

This was done on Regtest

1. The mediator suggests that BTC buyer get the trade amount.
2. The BTC buyer accepts it.
3. The mediator suggests a new resolution in which the BTC seller gets the trade amount.
4. The BTC seller accepts this one.
5. The BTC buyer doesn't get a chance to reject it as it's automatically accepted and the trade is closed.

Expected behaviour

The trader that accepted the first suggestion should also get a option to reject the second suggestion.

Actual behaviour

As soon as the trader that rejected the first suggestion accepts the second one, the payout transaction gets published.

Additional info

[BtcContributor]

I am taking a look.

@huey735 not sure if I am understanding well the steps.
If between step 2 and 3 the BTC seller rejects the mediation, automatically an arbitration is started and in this case the outcome will be forced without any accept/reject by the parties.
So I am not sure how to recreate your scenario where a second mediation could be requested.

Could you please explain that with more details? Sorry about that. Thanks.

Edit: chat with huey clarified the scenario. I am taking a look.

[huey735]

A rejection of mediation doesn't immediately trigger arbitration.

[BtcContributor]

I coordinated with @jmacxx. He will take care of this issue. Thanks!

[ghost]

Adding here so I don't forget. Requests from @huey735

• Make the resolution suggestion separate from closing of the ticket so users can continue to chat with mediator.
• It'd be great if after the DelayedPayoutTx is valid that the Traders had a way to move onto arbitration independently of the mediation ticket.