Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages under input fields are not updated #5005

Closed
Jakub-CZ opened this issue Dec 25, 2020 · 0 comments · Fixed by #5006
Closed

Error messages under input fields are not updated #5005

Jakub-CZ opened this issue Dec 25, 2020 · 0 comments · Fixed by #5006

Comments

@Jakub-CZ
Copy link
Contributor

Description

As user types into a validated text field, if the new string is still invalid but the error message (reason of invalidity) changed,
the message is not updated to reflect the new reason.

Version

c52d669

Steps to reproduce

  1. DAO -> Governance->Make Proposal->Proposal for changing a parameter
  2. Select BTC maker fee
  3. While the current value is 0.001, gradually type 0.0011. Notice the error messages displayed for each partially entered value.

Expected behaviour

The error message reflects the reason why the value in the text field is invalid.

E.g.: going from 0.00 to 0.001 should switch from "dust limit not allowed" to "must be different from current value".

Actual behaviour

The first error message that "snaps in" and is not updated when the reason for invalidity changes. One of the ways to get a correct message is to focus out of the field and then refocus the field again.

Screenshots

Below are the states of a field as the value 0.0011 is being entered, and then cleared again.
instant-error-message-update BEFORE

Device or machine

Windows 10, OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.9.1+1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant