Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow trade start if BitcoinJ is not fully synced #4727

Closed
chimp1984 opened this issue Oct 29, 2020 · 2 comments · Fixed by #4764
Closed

Don't allow trade start if BitcoinJ is not fully synced #4727

chimp1984 opened this issue Oct 29, 2020 · 2 comments · Fixed by #4764
Labels
a:bug in:trade-process

Comments

@chimp1984
Copy link
Contributor

Description

While BitcoinJ is syncing the lock time would be incorrectly calculated leading to a failed trade. Currently users could take and offer or offers of a maker can be taken during sync.

We should add for both maker and taker side the check that BitcoinJ need to be synced. The sync of a new block (veyry short time) can be ignored as the locktime has some tolerance built it to not fail in case both traders have a small difference of the block height.

Case of a user who had that problem:
#4707 (comment)
@chimp1984 chimp1984 mentioned this issue Oct 29, 2020
Closed
@mpowacht
Copy link

@chimp1984 thanks and kudos to this great community and this amazing project !! Bisq is incredible!

@ghost ghost mentioned this issue Nov 8, 2020
Merged
@mpowacht
Copy link

@chimp1984 Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug in:trade-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't allow trade start if BitcoinJ is not fully synced
3 participants
@ripcurlx @chimp1984 @mpowacht